Re: [Xen-devel] [PATCH OSSTEST 3/7] ts-debian-di-install: Install pv-menu-list in ARM guests, always.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST 3/7] ts-debian-di-install: Install 
pv-menu-list in ARM guests, always."):
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This package seems to be called `pv-grub-menu', not `pv-menu-list'.

> @@ -190,9 +190,18 @@ END
>  
>       $method_cfg = setup_netboot($tmpdir, $arch, $suite);
>  
> +     # We need the pv-menu-list package:
> +     # - On x86 when running pvgrub, since it only speaks grub1
> +     #   menu.lst syntax and by grub2 is now the only grub in
> +     #   Debian.

This comment seems mangled.  "and by grub2" ?  Also in "it only speaks
grub1", it would be clearer if "it" said "pvgrub".

> +     # - On ARM, which uses pygrub, because grub2 is not installed
> +     #   on ARM by default (except for, maybe, UEFI guests in the
> +     #   future, but not today).
> +     my $pvmenulst = ($bl eq "pvgrub" || $arch =~ /arm/);

"pvgrub" here is pvgrub1, not pv grub2.  This could perhaps be
clearer...

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel