Re: [Xen-devel] [Xen-users] "xl restore" leaks a file descriptor?

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-08-12 at 09:41 +0100, Ian Campbell wrote:
> On Tue, 2015-08-11 at 18:07 +0100, Wei Liu wrote:
> > 
> > I don't see how CLOEXEC would be of any use if xl doesn't actually exec
> > anything.
> 
> Duh, for some reason I thought daemonize would activate the CLOEXEC, but
> it's just fork without exec. Silly me.

FWIW I did manage to confirm that libxl isn't messing up the CLOEXEC state
of the FD, it correctly only clears it between the fork and exec when
spawning the save restore helper. Any messing which libxc does is safely
contained in that subprocess.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel