Re: [Xen-devel] [PATCH v10 06/11] xen: Introduce XEN_DOMCTL_soft_reset

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.08.15 at 21:57, <konrad.wilk@xxxxxxxxxx> wrote:
> On Tue, Jul 28, 2015 at 03:28:11PM +0200, Vitaly Kuznetsov wrote:
>> @@ -1038,6 +1045,32 @@ void domain_unpause_except_self(struct domain *d)
>>          domain_unpause(d);
>>  }
>>  
>> +int domain_soft_reset(struct domain *d)
>> +{
>> +    struct vcpu *v;
>> +    int rc;
>> +
>> +    spin_lock(&d->shutdown_lock);
>> +    for_each_vcpu ( d, v )
>> +        if ( !v->paused_for_shutdown )
>> +        {
>> +            spin_unlock(&d->shutdown_lock);
>> +            return -EINVAL;
>> +        }
>> +    spin_unlock(&d->shutdown_lock);
>> +
>> +    rc = evtchn_reset(d);
> 
> You do ignore the 'rc' value? In which case why not just
> do:
> 
>       (void)evtchn_reset(d);
> 
> Unless you want to return the 'rc' ?

It clearly needs to be returned.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel