[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3] x86, amd_ucode: Skip microcode updates for final levels

>>> On 11.08.15 at 17:28, <aravind.gopalakrishnan@xxxxxxx> wrote:
> On 8/11/2015 10:17 AM, Andrew Cooper wrote:
>>>>> +    0x01000098,
>>>>> +    0x0100009f,
>>>>> +    0x010000af
>>>>> +};
>>>>> +
>>>>> +static bool_t check_final_patch_levels(int cpu)
>>>> unsigned int
>>> I can change this too, but- Any specific reason for this?
>>> The other sanity checker or verification functions like
>>> verify_patch_size() or microcode_fits() return a bool_t too..
>> "int cpu" is the issue (I am guessing), not the return type.
> Thought about that too.. but all the microcode_ops functions accept an 
> 'int cpu'.
> I'm just using the same type in check_final_patch_levels().

And ideally all other bad examples would be fixed in a cleanup
patch too - CPU numbers can't be negative. In any event we
should aim at not proliferating such sub-optimal code.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.