Re: [Xen-devel] [PATCH for-4.6] libxl: fix libxl__build_hvm error code return path

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Aug 11, 2015 at 02:55:41PM +0100, Ian Campbell wrote:
> On Tue, 2015-08-11 at 14:48 +0100, Wei Liu wrote:
> > In 25652f23 ("tools/libxl: detect and avoid conflicts with RDM"), new
> > code was added to use rc to store libxl function call return value,
> > which complied to libxl coding style. That patch, however, didn't change
> > other locations where return value was stored in ret. In the end
> > libxl__build_hvm could return 0 when it failed.
> > 
> > Explicitly set rc to ERROR_FAIL in all error paths to fix this.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> You missed the path from libxl__domain_firmware, which incorrectly relies
> on rc being already initialised by the declaration (which per CODING_STYLE
> ought to be removed too).
> 
> However perhaps you prefer to leave those other two hunks until 4.7 and
> this patch is at least an improvement of sorts so:
> 

Yes. Roger already has a patch for 4.7 to fix error handling in this
function.

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel