Re: [Xen-devel] [PATCH OSSTEST v2] Arrange to test migration from the previous Xen version

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-08-03 at 17:01 +0100, Ian Campbell wrote:
> On Fri, 2015-07-24 at 17:28 +0100, Ian Campbell wrote:
> > @@ -191,6 +208,27 @@ create_build_jobs () {
> >                  revision_ovmf=$REVISION_OVMF
> >      done
> >  
> > +    if [ x$want_prevxen = xy ] ; then
> > +        if [ "x$REVISION_PREVXEN" = x ] ; then
> > +            echo >&2 "prevxen ?"; exit 1
> > +        fi
> 
> This breaks things with standalone mode, or any make-flight which didn't
> come from cr-daily-branch.
> 
> In such cases we don't have REVISION_XEN or TREE_XEN either, we just get
> the defaults.
> 
> I think we need to do something like select_prevxenbranch but to pick a
> xen.git branch name rather than an osstest branch name.
> 
> Or we quietly skip this test if REVISION_PREVXEN is not set.
> 
> One to chew on I think.

At the moment I'm somewhat inclined towards omitting the build-$ARCH-prev
job in this case but still creating the associated test jobs.

In standalone mode this may still be useful (maybe your hosts are already
configured and you want to run an individual step).

In production mode the test jobs will then fail their ts-build-check step,
which correctly reflects what has happened.

I think this is the effect of the following incremental patch.

Ian.

diff --git a/mfi-common b/mfi-common
index 737db99..810e533 100644
--- a/mfi-common
+++ b/mfi-common
@@ -208,10 +208,7 @@ create_build_jobs () {
                 revision_ovmf=$REVISION_OVMF
     done
 
-    if [ x$want_prevxen = xy ] ; then
-        if [ "x$REVISION_PREVXEN" = x ] ; then
-            echo >&2 "prevxen ?"; exit 1
-        fi
+    if [ x$want_prevxen = xy -a "x$REVISION_PREVXEN" != x ] ; then
         # TODO could find latest pass on that branch and attempt to reuse.
         #bfiprevxen=...
         #

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel