Re: [Xen-devel] [PATCH for-4.6 v2 4/4] oxenstored: move sd_notify_ready out of main loop

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 10, 2015 at 09:04:20AM +0100, Andrew Cooper wrote:
> On 10/08/2015 09:00, Wei Liu wrote:
> > Oxenstored only needs to notify systemd its readiness state once. Move
> > sd_notify_ready out of main loop.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Acked-by: Dave Scott <dave.scott@xxxxxxxxxxxxx>
> > ---
> > For 4.6: avoid wasting CPU cycles, easy to reason its correctness.
> >
> > There is a small risk that either I wrote the wrong code or I
> > misunderstand the usage of systemd API. However I've tested the modified
> > oxenstored it worked fine.
> > ---
> >  tools/ocaml/xenstored/xenstored.ml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/ocaml/xenstored/xenstored.ml 
> > b/tools/ocaml/xenstored/xenstored.ml
> > index f484024..42b8183 100644
> > --- a/tools/ocaml/xenstored/xenstored.ml
> > +++ b/tools/ocaml/xenstored/xenstored.ml
> > @@ -428,11 +428,11 @@ let _ =
> >             process_domains store cons domains
> >             in
> >  
> > +   if Systemd.launched_by_systemd () then
> > +           Systemd.sd_notify_ready ();
> >     while not !quit
> >     do
> >             try
> > -                        if Systemd.launched_by_systemd() then
> > -                                Systemd.sd_notify_ready ();
> 
> You have tabs/spaces issues here.
> 

Yeah. I know that. But that's what it used to be, not introduced by me.
Furthermore, it's removal, not addition, so I didn't bother sending out
another patch to adjust that.

> However, the two oxenstored patches are Tested-by: Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>.  XenServer testing over the weekend has
> shown no regressions.
> 

Thanks.

Wei.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel