Re: [Xen-devel] [PATCH v4 08/31] libxc: rework BSP initialization

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 07/08/15 13:06, Wei Liu wrote:
>
>>>> -    ctxt = xc_hypercall_buffer_alloc(dom->xch, ctxt, sizeof(*ctxt));
>>>> -    if ( ctxt == NULL )
>>>> -        return -1;
>>>> -
>>>>      DOMPRINTF_CALLED(dom->xch);
>>>>  
>>>>      /* misc stuff*/
>>>> @@ -259,13 +241,10 @@ int xc_dom_boot_image(struct xc_dom_image *dom)
>>>>          return rc;
>>>>  
>>>>      /* let the vm run */
>>>> -    memset(ctxt, 0, sizeof(*ctxt));
>>>> -    if ( (rc = dom->arch_hooks->vcpu(dom, ctxt)) != 0 )
>>>> +    if ( (rc = dom->arch_hooks->vcpu(dom)) != 0 )
>>>>          return rc;
>>>>      xc_dom_unmap_all(dom);
>>> This is not your problem, but this xc_dom_unmap_all is really
>>> suspicious.
>> I agree, xc_dom_release already calls xc_dom_unmap_all. I guess it's not
>> a big issue since xc_dom_boot_image is almost the last function called
>> when doing domain creation, but I'm also not that familiar with libxc in
>> order to figure out if there's a reason for calling xc_dom_unmap_all here.
>>
> Yeah, let's worry about that later.

:)  Make absolutely no assumptions about the correctness of the existing
code.

I got lead down several rabbit holes with migration v2 (one hole going
back to 2002 and the bitkeeper source history).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel