[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 01/31] libxl: fix libxl__build_hvm error handling

On Fri, Aug 07, 2015 at 01:28:32PM +0200, Roger Pau Monné wrote:
> El 07/08/15 a les 13.03, Wei Liu ha escrit:
> > On Fri, Aug 07, 2015 at 12:55:21PM +0200, Roger Pau Monné wrote:
> >> El 07/08/15 a les 12.49, Wei Liu ha escrit:
> >>> On Fri, Aug 07, 2015 at 12:17:38PM +0200, Roger Pau Monne wrote:
> >>>> With the current code in libxl__build_hvm it is possible for the 
> >>>> function to
> >>>> fail and still return 0.
> > 
> > I care about this bit, which states clearly there is a bug that needs
> > fixing.
> There are a bunch of error paths in this function that needs fixing,
> every error path below the call to libxl__domain_device_construct_rdm
> will simply return with rc = 0, because the return code of the functions
> is stored in ret, but the return code for libxl__build_hvm is fetched
> from rc.

I see. Arguably that's a bug in RDM series. Not a regression.  And I
think I should post a two-liner patch to change rc to ret. This would be
a short bug fix for 4.6.

That would then make your patch a pure refactoring patch and be ready to
be applied for 4.7.

The other option is to apply this patch for 4.6. Since you didn't tag
this patch for-4.6, I didn't have that thought at the time I saw it.

Which way do you prefer? If you want the latter please resend this
single patch, reword the commit message to make it clearer.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.