Re: [Xen-devel] [PATCH for-4.6 3/5] cxenstored: remove dead option

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Aug 06, 2015 at 02:49:28PM +0100, Ian Campbell wrote:
> On Thu, 2015-08-06 at 14:38 +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > For 4.6: remove dead code, risk free.
> 
> I'm pretty sure this isn't actually dead:
> 
> The 'm' option is handled by option parsing, setting the dom0_domid global.
> 
> xenbus_master_domid() returns dom0_domid and that is called by both
> dom0_init() and, for mini-os, xenbus_map().
> 
> So I think this is used by stub-xenstored somehow.
> 
> At the least we shouldn't remove the option without also removing all the
> above, and that is not 4.6 material at this point IMHO.
> 

Right. I will drop this patch.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel