[Xen-devel] [qemu-upstream-4.2-testing test] 60553: regressions - FAIL

[osstest service owner <osstest-admin@xxxxxxxxxxxxxx>]

flight 60553 qemu-upstream-4.2-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/60553/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-qemuu-win7-amd64  6 xen-boot           fail REGR. vs. 60207

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop       fail blocked in 60207

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-ovmf-amd64  9 debian-hvm-install      fail never pass
 test-amd64-amd64-xl-qemuu-ovmf-amd64  9 debian-hvm-install     fail never pass
 test-amd64-i386-xend-qemuu-winxpsp3 20 leak-check/check        fail never pass

version targeted for testing:
 qemuu                138906105dd47b9dc6b1e5010e81fc606983dd75
baseline version:
 qemuu                da2e633ec99da897f51f388217f070c53aea6674

Last test of basis    60207  2015-07-31 22:20:43 Z    5 days
Testing same since    60553  2015-08-03 19:06:47 Z    2 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefan Hajnoczi <stefanha@xxxxxxxxxx>
  Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

jobs:
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-i386-xl-qemuu-winxpsp3-vcpus1                     pass    
 test-amd64-i386-xend-qemuu-winxpsp3                          fail    
 test-amd64-amd64-xl-qemuu-winxpsp3                           pass    
 test-i386-i386-xl-qemuu-winxpsp3                             pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 138906105dd47b9dc6b1e5010e81fc606983dd75
Author: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date:   Mon Aug 3 14:07:02 2015 +0000

    Fix release_drive on unplugged devices (pci_piix3_xen_ide_unplug)
    
    pci_piix3_xen_ide_unplug should completely unhook the unplugged
    IDEDevice from the corresponding BlockBackend, otherwise the next call
    to release_drive will try to detach the drive again.
    
    Suggested-by: Kevin Wolf <kwolf@xxxxxxxxxx>
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

commit 3b841b4daa66fba7422697df8d4af2e96bba89ad
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Wed Jul 15 18:17:04 2015 +0100

    rtl8139: check TCP Data Offset field
    
    The TCP Data Offset field contains the length of the header.  Make sure
    it is valid and does not exceed the IP data length.
    
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

commit e2c8930853198fc4c9e50e46653bc1e577f785c8
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Wed Jul 15 18:17:03 2015 +0100

    rtl8139: skip offload on short TCP header
    
    TCP Large Segment Offload accesses the TCP header in the packet.  If the
    packet is too short we must not attempt to access header fields:
    
      tcp_header *p_tcp_hdr = (tcp_header*)(eth_payload_data + hlen);
      int tcp_hlen = TCP_HEADER_DATA_OFFSET(p_tcp_hdr);
    
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

commit a1c76be898c9da3a4a6c71d21e5ca6b8591fc9f9
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Wed Jul 15 18:17:02 2015 +0100

    rtl8139: check IP Total Length field
    
    The IP Total Length field includes the IP header and data.  Make sure it
    is valid and does not exceed the Ethernet payload size.
    
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

commit e721b75d1d69f80c229b1997e1ddf88067bebf69
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Wed Jul 15 18:17:01 2015 +0100

    rtl8139: check IP Header Length field
    
    The IP Header Length field was only checked in the IP checksum case, but
    is used in other cases too.
    
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

commit b70113afe4e51f8ac69840aa2a873e398a4c3436
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Wed Jul 15 18:17:00 2015 +0100

    rtl8139: skip offload on short Ethernet/IP header
    
    Transmit offload features access Ethernet and IP headers the packet.  If
    the packet is too short we must not attempt to access header fields:
    
      int proto = be16_to_cpu(*(uint16_t *)(saved_buffer + 12));
      ...
      eth_payload_data = saved_buffer + ETH_HLEN;
      ...
      ip = (ip_header*)eth_payload_data;
      if (IP_HEADER_VERSION(ip) != IP_HEADER_VERSION_4) {
    
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

commit 132388208dba1c9d7fb071c39d3a5d00fec3eb1d
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Wed Jul 15 18:16:59 2015 +0100

    rtl8139: drop tautologous if (ip) {...} statement
    
    The previous patch stopped using the ip pointer as an indicator that the
    IP header is present.  When we reach the if (ip) {...} statement we know
    ip is always non-NULL.
    
    Remove the if statement to reduce nesting.
    
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

commit 92c2288071d701e993f0b6cf6572bb95e1209017
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Wed Jul 15 18:16:58 2015 +0100

    rtl8139: avoid nested ifs in IP header parsing
    
    Transmit offload needs to parse packet headers.  If header fields have
    unexpected values the offload processing is skipped.
    
    The code currently uses nested ifs because there is relatively little
    input validation.  The next patches will add missing input validation
    and a goto label is more appropriate to avoid deep if statement nesting.
    
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel