Re: [Xen-devel] [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run time

[Ingo Molnar <mingo@xxxxxxxxxx>]

* Willy Tarreau <w@xxxxxx> wrote:

> @@ -276,6 +282,15 @@ asmlinkage int sys_modify_ldt(int func, void __user *ptr,
>  {
>       int ret = -ENOSYS;
>  
> +     if (!sysctl_modify_ldt) {
> +             printk_ratelimited(KERN_INFO
> +                     "Denied a call to modify_ldt() from %s[%d] (uid: %d)."
> +                     " Adjust sysctl if this was not an exploit attempt.\n",
> +                     current->comm, task_pid_nr(current),
> +                     from_kuid_munged(current_user_ns(), current_uid()));

UI nit: so this message should really tell the user _which_ sysctl to 
configure, 
instead of passive-aggressively alluding to the fact that there's a sysctl 
somewhere that might do the trick...

Thanks,

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel