[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH for-4.6 v2 0/6] Fix libxl TOOLSTACK records for migration v2

The libxl blob for toolstack records was not 32/64bit safe.  In 64bit
builds, it had an extra 4 bytes of padding due to alignment, and because
of the pointer arithmatic used to build it, leaked 4 bytes of libxl heap
into the stream.

Respecify XENSTORE_DATA as EMULATOR_XENSTORE_DATA and take remedial
action to prevent this bitness issue escaping into a Xen release.

The original patches 1&2 of this series have already been accepted, so all
other patches have shifted up by two.

Summary of Modified/Acks:

Andrew Cooper (6):
M  tools/libxl: Make libxl__conversion_helper_abort() safe to use
M  tools/libxl: Save and restore EMULATOR_XENSTORE_DATA content
M  tools/libxl: Prepare to write multiple records with EMULATOR headers
MA libxl/save&restore&convert: Switch to new EMULATOR_XENSTORE_DATA records
 A tools/libxl: Drop all legacy "toolstack" record infrastructure

   docs/specs/libxl-migration-stream.pandoc   |   83 +++++---
   tools/libxl/libxl_convert_callout.c        |    2 +
   tools/libxl/libxl_dom.c                    |  293 
   tools/libxl/libxl_internal.h               |   15 +-
   tools/libxl/libxl_sr_stream_format.h       |   10 +-
   tools/libxl/libxl_stream_read.c            |   27 ++-
   tools/libxl/libxl_stream_write.c           |  194 +++++++++++-------
   tools/python/scripts/convert-legacy-stream |   68 ++++++-
   tools/python/xen/migration/legacy.py       |   40 +++-
   tools/python/xen/migration/libxl.py        |   70 +++++--
   tools/python/xen/migration/tests.py        |    2 +-
   11 files changed, 467 insertions(+), 337 deletions(-)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.