Re: [Xen-devel] [PATCH for-4.6 7/8] libxl/save&restore&convert: Switch to new EMULATOR_XENSTORE_DATA records

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.6 7/8] 
libxl/save&restore&convert: Switch to new EMULATOR_XENSTORE_DATA records"):
> On 29/07/15 13:00, Ian Jackson wrote:
> >> +        rc = libxl__restore_emulator_xenstore_data(
> > ( in wrong place.
> >
> > But apart from that it looks fine.
> 
> I am sorry, but this request is unreasonable IMO.
> 
> This is a function call, not an integer assignment.  Moving the bracket
> onto the next line is counterintuitive, and I cannot find a single style
> anywhere which suggests it being a rational thing to do.

I have done a search and AFAICT it is done the majority of the time,
by some considerable margin, in libxl.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel