Re: [Xen-devel] [PATCH OSSTEST v2 1/5] ms-planner: Propagate a booking's Job to the plan

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 1/5] ms-planner: Propagate a booking's 
Job to the plan"):
> This needs to be done in several places:
> 
> - When booking resources (cmd: book-resources), to initially propagate
>   from the booking (e.g. from ts-hosts-allocate-Executive's input).
> - On reset (cmd: reset) so that the Events corresponding to actual
>   allocations retain there Job.
                       ^^^^^
                       their

> - When retrieving the plan (cmd: get-plan), so it would be available
>   for logging etc (I don't think this is currently used)

get-plan is used by each job in turn to fetch the existing plan so
they can edit it.  So the parenthetical should be removed.

> This patch has been deployed on the Cambridge instance for testing
> with no ill-effects.

This doesn't currently actually supply a Job anywhere ?  Ah yes I see
that in 3/5, but it would be worth mentioning in the commit message.


Aside from these three observations about the commit message.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel