Re: [Xen-devel] [PATCH v3 09/32] libxl: switch HVM domain building to use xc_dom_* helpers

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jul 28, 2015 at 04:26:15PM +0200, Roger Pau Monné wrote:
> El 28/07/15 a les 13.22, Wei Liu ha escrit:
> > On Fri, Jul 03, 2015 at 01:34:47PM +0200, Roger Pau Monne wrote:
> >> Now that we have all the code in place HVM domain building in libxl can be
> >> switched to use the xc_dom_* family of functions, just like they are used 
> >> in
> >> order to build PV guests.
> >>
> >> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Mostly looks good. Some nits below.
> 
> Thanks for the review.
> 
> >> ---
> >>  tools/libxl/libxl_dom.c      | 224 
> >> +++++++++++++++++++++++++------------------
> >>  tools/libxl/libxl_internal.h |   2 +-
> >>  tools/libxl/libxl_vnuma.c    |  12 ++-
> >>  3 files changed, 139 insertions(+), 99 deletions(-)
> >>
> >> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> >> index 2bae277..480b7e7 100644
> >> --- a/tools/libxl/libxl_dom.c
> >> +++ b/tools/libxl/libxl_dom.c
> >> @@ -609,6 +609,64 @@ static int set_vnuma_info(libxl__gc *gc, uint32_t 
> >> domid,
> >>      return rc;
> >>  }
> >>  
> >> +static int libxl__build_dom(libxl__gc *gc, uint32_t domid,
> >> +             libxl_domain_build_info *info, libxl__domain_build_state 
> >> *state,
> >> +             struct xc_dom_image *dom)
> >> +{
> >> +    libxl_ctx *ctx = libxl__gc_owner(gc);
> > 
> > No need to have this line.
> 
> But ctx is needed...
> 
> >> +    uint64_t mem_kb;
> >> +    int ret;
> >> +
> >> +    if ( (ret = xc_dom_boot_xen_init(dom, ctx->xch, domid)) != 0 ) {
>                                               ^ here.

Use CTX macro here. Sorry I missed this.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel