Re: [Xen-devel] [PATCH v3 06/32] libxc: make arch_setup_boot{init/late} xc_dom_arch hooks

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 03, 2015 at 01:34:44PM +0200, Roger Pau Monne wrote:
> This should not introduce any functional change.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---

> +/* ------------------------------------------------------------------------ 
> */
> +
> +static struct xc_dom_arch xc_dom_32_pae = {
> +    .guest_type = "xen-3.0-x86_32p",
> +    .native_protocol = XEN_IO_PROTO_ABI_X86_32,
> +    .page_shift = PAGE_SHIFT_X86,
> +    .sizeof_pfn = 4,
> +    .alloc_magic_pages = alloc_magic_pages,
> +    .count_pgtables = count_pgtables_x86_32_pae,
> +    .setup_pgtables = setup_pgtables_x86_32_pae,
> +    .start_info = start_info_x86_32,
> +    .shared_info = shared_info_x86_32,
> +    .vcpu = vcpu_x86_32,
> +    .meminit = meminit_pv,
> +    .bootearly = bootearly,
> +    .bootlate = bootlate_pv,
> +};
> +
> +static struct xc_dom_arch xc_dom_64 = {
> +    .guest_type = "xen-3.0-x86_64",
> +    .native_protocol = XEN_IO_PROTO_ABI_X86_64,
> +    .page_shift = PAGE_SHIFT_X86,
> +    .sizeof_pfn = 8,
> +    .alloc_magic_pages = alloc_magic_pages,
> +    .count_pgtables = count_pgtables_x86_64,
> +    .setup_pgtables = setup_pgtables_x86_64,
> +    .start_info = start_info_x86_64,
> +    .shared_info = shared_info_x86_64,
> +    .vcpu = vcpu_x86_64,
> +    .meminit = meminit_pv,
> +    .bootearly = bootearly,
> +    .bootlate = bootlate_pv,
> +};
> +

One thing I notice in this series is that these hunks are moved
repeatedly in patches. Might be worth moving them right to the end /
only adding new functions before them to reduce patch size.

Just an observation. Not a blocker for this series though. If it turns
out hard to do just ignore that comment.

> +static void __init register_arch_hooks(void)
> +{
> +    xc_dom_register_arch_hooks(&xc_dom_32_pae);
> +    xc_dom_register_arch_hooks(&xc_dom_64);
> +}
> +
>  int xc_dom_feature_translated(struct xc_dom_image *dom)
>  {
>      /* Guests running inside HVM containers are always auto-translated. */
> -- 
> 1.9.5 (Apple Git-50.3)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel