Re: [Xen-devel] [PATCH v2] xenconsole: Ensure exclusive access to console using locks

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-07-24 at 16:47 +0200, Martin Lucina wrote:
> If more than one instance of xenconsole is run against the same DOMID
> then each instance will only get some data. This change ensures
> exclusive access to the console by obtaining an exclusive lock on
> <XEN_LOCK_DIR>/xenconsole.<DOMID>.
> 
> The locking strategy used is based on
> tools/libxl/libxl_internal.c:libxl__lock_domain_userdata().

I'll let Ian deal with reviewing the locking but, only one small comment
from me:
> 
> diff --git a/tools/console/Makefile b/tools/console/Makefile
> index 71f8088..1ce5590 100644
> --- a/tools/console/Makefile
> +++ b/tools/console/Makefile

I forgot to mention adding the paths file to the clean rule too, sorry.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel