Re: [Xen-devel] [PATCH] xen: arm: Document xenheap_megabytes limitation

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-23 at 17:49 +0100, Julien Grall wrote:
> Hi Chris,
> 
> Thank you for patch.
> 
> On 23/07/15 17:31, Chris (Christopher) Brand wrote:
> > In setup_mm(), the value passed as xenheap_megabytes gets
> > converted to pages and passed to setup_xenheap_mappings(),
> > which in turn passes it to create_32mb_mappings(), which
> > contains an ASSERT that the value passed is a multiple of
> > 32MB. So specifying any value that is not an integer multiple
> > of 32 will cause Xen to hit this assert and fail to boot.
> > 
> > Signed-off-by: Chris Brand <chris.brand@xxxxxxxxxxxx>
> 
> I wondering if it would worth to add a check in the code to ensure 
> that
> it's a multiple of 32MB?

Arguably we have that in the form of the assert/panic, but perhaps
there should be a nicer message.

> Nonetheless:
> 
> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked + applied.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel