Re: [Xen-devel] [PATCH OSSTEST v3 01/13] toolstack: save / restore check

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-23 at 17:45 +0100, Wei Liu wrote:
> On Thu, Jul 23, 2015 at 05:16:45PM +0100, Ian Campbell wrote:
> > On Wed, 2015-07-22 at 11:13 +0100, Wei Liu wrote:
> > > +++ b/Osstest/Toolstack/libvirt.pm
> > > [...]
> > > +sub saverestore_check ($) {
> > > +    my ($self) = @_;
> > > +    return check_for_command($self, "save");
> > 
> > I just noticed that in a later patch you parse the capabilities xml 
> > to
> > check for migration support. Is save/restore reflected there too?
> > Parsing structured output from a command designed to produce 
> > machine
> > readable output out to be preferred to parsing help output if 
> > possible.
> > 
> 
> Anthony helped me check that. The ability to save and restore is not
> reflected in xml output of "virsh capabilities".

Thanks for checking, in that case we should do as you have done (i.e.
my ack stands).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel