[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] oxenstored: link in the systemd system library


  • To: Jonathan Creekmore <jonathan.creekmore@xxxxxxxxx>
  • From: Dave Scott <Dave.Scott@xxxxxxxxxx>
  • Date: Thu, 23 Jul 2015 09:02:27 +0000
  • Accept-language: en-GB, en-US
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 23 Jul 2015 09:02:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: AQHQxMoqhHcWX2DhfUe1+VltEHeIpp3ooYAA
  • Thread-topic: [PATCH] oxenstored: link in the systemd system library

> On 22 Jul 2015, at 23:02, Jonathan Creekmore <jonathan.creekmore@xxxxxxxxx> 
> wrote:
> 
> If systemd is configured for use AND you are building oxenstored, the C
> systemd library must be linked in to the oxenstored binary instead of
> just into the static ocaml stub.

This sounds sensible to me,

Acked-by: David Scott <dave.scott@xxxxxxxxxx>

> 
> Signed-off-by: Jonathan Creekmore <jonathan.creekmore@xxxxxxxxx>
> ---
> tools/ocaml/xenstored/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/ocaml/xenstored/Makefile b/tools/ocaml/xenstored/Makefile
> index d861f11..38ca347 100644
> --- a/tools/ocaml/xenstored/Makefile
> +++ b/tools/ocaml/xenstored/Makefile
> @@ -64,9 +64,11 @@ XENSTOREDLIBS = \
>       -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xb 
> $(OCAML_TOPLEVEL)/libs/xb/xenbus.cmxa \
>       -ccopt -L -ccopt $(XEN_ROOT)/tools/libxc
> 
> +XENSTORED_LDFLAGS-$(CONFIG_SYSTEMD) += -cclib $(SYSTEMD_LIBS)
> +
> PROGRAMS = oxenstored
> 
> -oxenstored_LIBS = $(XENSTOREDLIBS)
> +oxenstored_LIBS = $(XENSTOREDLIBS) $(XENSTORED_LDFLAGS-y)
> oxenstored_OBJS = $(OBJS)
> 
> OCAML_PROGRAM = oxenstored
> -- 
> 2.1.4
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.