Re: [Xen-devel] [v10][PATCH 16/16] tools: parse to enable new rdm policy parameters

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Tiejun Chen writes ("[v10][PATCH 16/16] tools: parse to enable new rdm policy 
parameters"):
> This patch parses to enable user configurable parameters to specify
> RDM resource and according policies which are defined previously,
> 
> Global RDM parameter:
>     rdm = "strategy=host,policy=strict/relaxed"
> Per-device RDM parameter:
>     pci = [ 'sbdf, rdm_policy=strict/relaxed' ]
> 
> Default per-device RDM policy is same as default global RDM policy as being
> 'relaxed'. And the per-device policy would override the global policy like
> others.
> 
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

For clarity:

I am not acking this patch, primarily because I am not happy with the
code in xlu_rdm_parse which is (a) the result of repeated
clone-and-hack and (b) consists of ad-hoc string pointer fiddling.

If I had been able to review this patch earlier in the release cycle I
would be explictly nacking this patch.  It is true that maybe someone
will have some time to clean this up later; but in practice it often
turns out that they don't - which is why we usually try not to accept
patches on the basis of promises to do further cleanup.

However, I am late to this party.  I first made this complaint in
response to v7 on the 9th of July.  Under the circumstances I am going
to stand aside and neither ack nor nack this patch.

The rules then say that the patch may be committed given that it has
Wei's ack as a tools maintainer.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel