Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

[George Dunlap <dunlapg@xxxxxxxxx>]

On Mon, Jul 20, 2015 at 7:16 AM, Tiejun Chen <tiejun.chen@xxxxxxxxx> wrote:
> Now use the hypervisor-supplied memory map to build our final e820 table:
> * Add regions for BIOS ranges and other special mappings not in the
>   hypervisor map
> * Add in the hypervisor supplied regions
> * Adjust the lowmem and highmem regions if we've had to relocate
>   memory (adding a highmem region if necessary)
> * Sort all the ranges so that they appear in memory order.
>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> ---
> v10:
>
> * Instead of correcting e820, I'd like to correct memory_map.map[]
>   and then copy them into e820 directly. I think this can make sure
>   hvm_info, memory_map.map[] and e820 are on the same page.

Actually, now that you mention it -- this should probably happen
instead when we update hvm_info->{low,high}_mem_pgend.

I'm happy to leave this where it is for now, so with Jan's comments
addressed (in particular, incrementing nr_map):

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

But if we have time it might be better to pull the loop in pci_setup()
which moves the memory out into a function, and have that function
modify the lowmem and highmem map[] entries at the same time we modify
low_mem_pgend and high_mem_pgend.  Alternately, you could put that on
your list of clean-ups to hvmloader for 4.7.

Thanks,
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel