Re: [Xen-devel] [v8][PATCH 06/16] hvmloader/pci: disable all pci devices conflicting with rdm

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.07.15 at 15:21, <tiejun.chen@xxxxxxxxx> wrote:
> I guess something like this,
> 
>                       ...
>                          pci_writew(devfn, PCI_COMMAND, ~cmd);
>                          /* Jump next device. */
>                          goto check_next_device;
>                      }
>                  }
>              }
>          }
>   check_next_device:
>      }
> }

Except that this isn't valid C (no statement following the label). I can
accept goto-s for some error handling cases where the alternatives
might be considered even more ugly than using goto. But the way
this or your original proposal look, I'd rather not have goto-s used
like this.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel