[Xen-devel] [PATCH] xen/arm: gicv3: Update comment for ICC_CTLR_EL1

[Julien Grall <julien.grall@xxxxxxxxxx>]

Xen is using EOImode 1 which means that EOI drops the priority and DIR
deactivates the interrupt.

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
---
 xen/arch/arm/gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 2033951..d1db1ce 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -719,7 +719,7 @@ static int __cpuinit gicv3_cpu_init(void)
     /* Set priority mask register */
     WRITE_SYSREG32(DEFAULT_PMR_VALUE, ICC_PMR_EL1);
 
-    /* EOI drops priority too (mode 0) */
+    /* EOI drops priority, DIR deactivates the interrupt (mode 1) */
     WRITE_SYSREG32(GICC_CTLR_EL1_EOImode_drop, ICC_CTLR_EL1);
 
     /* Enable Group1 interrupts */
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel