Re: [Xen-devel] [PATCH v2 19/20] xen/privcmd: Add support for Linux 64KB page granularity

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Boris,

On 14/07/2015 17:28, Boris Ostrovsky wrote:
> On 07/13/2015 06:05 PM, Julien Grall wrote:
> > On 13/07/2015 22:13, Boris Ostrovsky wrote:
> > > On 07/09/2015 04:42 PM, Julien Grall wrote:
> > > > -
> > > >   struct remap_data {
> > > >       xen_pfn_t *fgmfn; /* foreign domain's gmfn */
> > > > +    xen_pfn_t *efgmfn; /* pointer to the end of the fgmfn array */
> > > It might be better to keep size of fgmfn array instead.
> > It would means to have an other variable to check that we are at the
> > end the array.
>
> I thought that's what h_iter is. Is it not?
h_iter is for the number of xen pfn in a Linux page. This is because the 
Linux privcmd interface is working with 4KB page and there may not be 
enough to fill a 64KB page.
So we need another counter for the total number of foreign domain's gmfn.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel