Re: [Xen-devel] [PATCH OSSTEST v2 06/13] toolstack/libvirt: guest migrate, save and restore support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:

Perhaps the libvirt part of the check_for_command stuff ought to be
moved here? Otherwise we are claiming support before the code is
actually willing to try to do so.

> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  Osstest/Toolstack/libvirt.pm | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
> index ddf84df..3dc1856 100644
> --- a/Osstest/Toolstack/libvirt.pm
> +++ b/Osstest/Toolstack/libvirt.pm
> @@ -105,17 +105,22 @@ sub saverestore_check ($) {
>  
>  sub migrate ($) {
>      my ($self,$gho,$dst,$timeout) = @_;
> -    die "Migration is not yet supported on libvirt.";
> +    my $ho = $self->{Host};
> +    my $gn = $gho->{Name};
> +    target_cmd_root($ho, "virsh migrate $gn $dst", $timeout);
>  }
>  
>  sub save ($$$$) {
>      my ($self,$gho,$f,$timeout) = @_;
> -    die "Save is not yet supported on libvirt.";
> +    my $ho = $self->{Host};
> +    my $gn = $gho->{Name};
> +    target_cmd_root($ho, "virsh save $gn $f", $timeout);
>  }
>  
>  sub restore ($$$$) {
>      my ($self,$gho,$f,$timeout) = @_;
> -    die "Restore is not yet supported on libvirt.";
> +    my $ho = $self->{Host};
> +    target_cmd_root($ho, "virsh restore $f", $timeout);
>  }
>  
>  1;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel