Re: [Xen-devel] [PATCH v3 2/2] x86/vm_event: toggle singlestep from vm_event response

["Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>]

On Wed, Jul 8, 2015 at 10:39 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 07.07.15 at 15:52, <tlengyel@xxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -6431,6 +6431,17 @@ int hvm_debug_op(struct vcpu *v, int32_t op)
>      return rc;
>  }
>
> +void hvm_toggle_singlestep(struct vcpu *v)
> +{
> +    ASSERT(atomic_read(&v->pause_count));
> +
> +    /* This feature may only be available on Intel CPUs. */
> +    if ( !cpu_has_vmx || !hvm_funcs.is_singlestep_supported() )

Same here regarding use of hvm_funcs. And you should use
cpu_has_vmx here or in the wrapper - instead the wrapper
should check whether the hook is NULL.

Ack.
 

Jan

Thanks,

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel