Re: [Xen-devel] [PATCH v6 07/16] x86/hvm: unify dpci portio intercept with standard portio intercept

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.15 at 18:25, <paul.durrant@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/intercept.c
> +++ b/xen/arch/x86/hvm/intercept.c
> @@ -125,10 +125,7 @@ int hvm_process_io_intercept(const struct hvm_io_handler 
> *handler,
>  {
>      struct vcpu *curr = current;
>      struct hvm_vcpu_io *vio = &curr->arch.hvm_vcpu.hvm_io;
> -    const struct hvm_io_ops *ops =
> -        (p->type == IOREQ_TYPE_COPY) ?
> -        &mmio_ops :
> -        &portio_ops;
> +    const struct hvm_io_ops *ops = handler->ops;

Ah, I see these odd many line things go away here again. In that case
you may not bother fiddling with such in the earlier patch(es). But those
that survive till the end of the series I'd prefer to see shortened.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel