Re: [Xen-devel] [PATCH] x86: correct socket_cpumask allocation for AP

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.07.15 at 11:36, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> @@ -84,11 +85,21 @@ void *stack_base[NR_CPUS];
>  static void smp_store_cpu_info(int id)
>  {
>      struct cpuinfo_x86 *c = cpu_data + id;
> +    unsigned int socket;
>  
>      *c = boot_cpu_data;
>      if ( id != 0 )
> +    {
>          identify_cpu(c);
>  
> +        socket = cpu_to_socket(id);
> +        if ( !socket_cpumask[socket] )
> +        {
> +            socket_cpumask[socket] = secondary_socket_cpumask;
> +            secondary_socket_cpumask = NULL;

I don't think this will build with small enough NR_CPUS. Which
raises the question whether the use of cpumask_var_t is suitable
here in the first place.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel