Re: [Xen-devel] [PATCH v3 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.07.15 at 17:33, <lichong659@xxxxxxxxx> wrote:
> On Tue, Jul 7, 2015 at 3:59 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 29.06.15 at 04:44, <lichong659@xxxxxxxxx> wrote:
>>> +    case XEN_DOMCTL_SCHEDOP_putvcpuinfo:
>>> +        spin_lock_irqsave(&prv->lock, flags);
>>> +        for( index = 0; index < op->u.v.nr_vcpus; index++ )
>>> +        {
>>> +            if ( copy_from_guest_offset(&local_sched,
>>> +                    op->u.v.vcpus, index, 1) )
>>> +            {
>>> +                rc = -EFAULT;
>>> +                break;
>>> +            }
>>> +            if ( local_sched.vcpuid >= d->max_vcpus
>>> +                    || d->vcpu[local_sched.vcpuid] == NULL )
>>> +            {
>>> +                rc = -EINVAL;
>>> +                break;
>>> +            }
>>> +            svc = rt_vcpu(d->vcpu[local_sched.vcpuid]);
>>> +            svc->period = MICROSECS(local_sched.s.rtds.period);
>>> +            svc->budget = MICROSECS(local_sched.s.rtds.budget);
>>
>> Are all input values valid here?
> 
> Vcpuid, Period and budget have been validated in libxl. But we can
> still repeat that validation here, if it's needed.

Yes, absolutely. Tool stacks may not be fully trusted (namely in
disaggregated setups).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel