| 
    
 [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [OSSTEST PATCH 05/13] Reporting: report_run_getinfo produces ColourAttr
 Ian Campbell writes ("Re: [OSSTEST PATCH 05/13] Reporting: report_run_getinfo 
produces ColourAttr"):
> On Mon, 2015-06-29 at 18:14 +0100, Ian Jackson wrote:
...
> > -   return { Summary => $summary, Colour => $colour };
> > +   return {
> > +       Summary => $summary,
> > +       ColourAttr => " bgcolor=\"$colour\"",
> 
> FWIW all the uses have a space before there $ri->{ColourAttr}, so
> strictly you don't need it here, I think.
Ah yes.
> Nonetheless:
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Thanks.  I will remove that space and keep your ack.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
 
 
  | 
  
![]()  | 
            
         Lists.xenproject.org is hosted with RackSpace, monitoring our  |