Re: [Xen-devel] [PATCH] xl: Change output from xl -N create to be more useful

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH] xl: Change output from xl -N create to be more 
useful"):
> On Fri, Jun 26, 2015 at 03:29:15PM +0100, Ian Jackson wrote:
...
> > Note that this change is NOT BACKWARDS COMPATIBLE.  But it would only
> > adversely affects anyone who uses `xl -N create' and then saves and
> > processes the JSON.  (The output from xl list et al is not changed; it
> > normally needs the domid.)  Such a user should probably have already
> > have complained about the infelicitous output.  If they haven't it
> > would be simple enough for them to bookend the output so as to provide
> > compatible output.
> > 
> > If this backward compatibility problem is considered a blocker for
> > this patch, then I will respin, with one of the following two
> > workarounds:
> >   - A new option to force sane output
> >   - Generate output which contains the domain config twice,
> >     once directly in the main struct, and a copy in "config"
> 
> I don't think keeping a broken interface for the sake of backward
> compatibility is worth it.

The interface isn't unuseable.  You just have to use jq(1) or
something to transform the output.

AFAIAA we have no in-tree consumers of libxl json domain configs and
further I'm not aware of any out-of-tree consumers apart from the one
I just introduced into the xs-ring3 ao abort test suite.

But, thanks for the favourable opinion :-).

> Actually you may want to update main_config_update, which also prints
> out domain configuration. Then remove the will-be-defunct
> printf_info{,_one_json}.

I'll look into doing this, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel