Re: [Xen-devel] [PATCH 34/35] libxl: libxl__ev_child pass actual pid to callback

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jun 25, 2015 at 06:44:34PM +0100, Ian Jackson wrote:
> The callbacks actually ignore this except for logging, but we should
> log the correct pid.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
> v4: New patch in this version of the series.
> ---
>  tools/libxl/libxl_fork.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_fork.c b/tools/libxl/libxl_fork.c
> index 144208a..4486687 100644
> --- a/tools/libxl/libxl_fork.c
> +++ b/tools/libxl/libxl_fork.c
> @@ -447,9 +447,10 @@ static int perhaps_sigchld_needed(libxl__gc *gc, bool 
> creating)
>  static void childproc_reaped_ours(libxl__egc *egc, libxl__ev_child *ch,
>                                   int status)
>  {
> +    pid_t pid = ch->pid;
>      LIBXL_LIST_REMOVE(ch, entry);
>      ch->pid = -1;
> -    ch->callback(egc, ch, ch->pid, status);
> +    ch->callback(egc, ch, pid, status);
>  }
>  
>  static int childproc_reaped(libxl__egc *egc, pid_t pid, int status)
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel