Re: [Xen-devel] [v2] nested EPT: fix the handling of nested EPT

["Li, Liang Z" <liang.z.li@xxxxxxxxx>]

> Please don't forget to Cc the maintainer (recently changed, now added).
> 
> > @@ -1076,6 +1077,9 @@ void ept_sync_domain(struct p2m_domain *p2m)
> >
> >      ASSERT(local_irq_is_enabled());
> >
> > +    if ( nestedhvm_enabled(d) && !p2m_is_nestedp2m(p2m) ) {
> > +        p2m_flush_nestedp2m(d);
> > +    }
> >      /*
> 
> Coding style: Braces aren't really needed here, but you should leave a blank
> line between your addition and the following comment.
> 
> > --- a/xen/arch/x86/mm/p2m.c
> > +++ b/xen/arch/x86/mm/p2m.c
> > @@ -1742,6 +1742,10 @@ p2m_flush_table(struct p2m_domain *p2m)
> >      ASSERT(page_list_empty(&p2m->pod.super));
> >      ASSERT(page_list_empty(&p2m->pod.single));
> >
> > +    if ( p2m->np2m_base == P2M_BASE_EADDR ) {
> > +        p2m_unlock(p2m);
> > +        return;
> > +    }
> >      /* This is no longer a valid nested p2m for any address space */
> 
> Since braces are needed here, they should be placed properly.
> Same comment as above regarding the missing blank line.

OK. It will be changed.

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel