Re: [Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/06/15 10:02, Jan Beulich wrote:
> Some of the generic hooks were unused altogether - drop them.
>
> Some of the hooks were used only to handle calls from the specific
> vendor's code (SVM) - drop them too.
>
> Several more hooks were pointlessly implementaed as out-of-line
> functions, when most (all?) other HVM hooks use inline ones - make
> them inlines. None of them are implemented by only one of SVM or VMX,
> so also drop the conditionals. Funnily nhvm_vmcx_hap_enabled(), having
> return type bool_t, nevertheless returned -EOPNOTSUPP.
>
> nhvm_vmcx_guest_intercepts_trap() and its hook and implementations are
> being made return bool_t, as they should have been from the beginning
> (its sole caller only checks for a non-zero result).
>
> Finally, make static whatever can as a result be static.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

That is a healthy quantity of deletion.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel