Re: [Xen-devel] [v4][PATCH 13/19] tools/libxc: check to set args.mmio_size before call xc_hvm_build

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 23, 2015 at 05:57:24PM +0800, Tiejun Chen wrote:
> After commit 5dff8e9eedc7, "libxc/libxl: fill xc_hvm_build_args in
> libxl" is introduced, we won't check to set args.mmio_size inside
> xc_hvm_build as before. So instead, we need to do this before call
> that.
> 
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Sigh. I missed this because libxl doesn't use this function and there is
no in tree xend anymore.

I think you should move this earlier in this series. Presumably your RDM
changes depend on this.

Wei.

> ---
> v4:
> 
> * Separate this from currenpt patch #14 since this is specific to xc.
> 
>  tools/libxc/xc_hvm_build_x86.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/libxc/xc_hvm_build_x86.c b/tools/libxc/xc_hvm_build_x86.c
> index 003ea06..7343e87 100644
> --- a/tools/libxc/xc_hvm_build_x86.c
> +++ b/tools/libxc/xc_hvm_build_x86.c
> @@ -754,6 +754,8 @@ int xc_hvm_build_target_mem(xc_interface *xch,
>      args.mem_size = (uint64_t)memsize << 20;
>      args.mem_target = (uint64_t)target << 20;
>      args.image_file_name = image_name;
> +    if ( args.mmio_size == 0 )
> +        args.mmio_size = HVM_BELOW_4G_MMIO_LENGTH;
>  
>      return xc_hvm_build(xch, domid, &args);
>  }
> -- 
> 1.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel