Re: [Xen-devel] [PATCH] x86/HVM: EOI handling function adjustments

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.06.15 at 15:29, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 18/06/15 13:51, Jan Beulich wrote:
>> -void vlapic_handle_EOI_induced_exit(struct vlapic *vlapic, int vector)
>> +void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector)
>>  {
>> +    struct domain *d = vlapic_domain(vlapic);
>> +
>>      if ( vlapic_test_and_clear_vector(vector, 
>> &vlapic->regs->data[APIC_TMR]) )
>> -        vioapic_update_EOI(vlapic_domain(vlapic), vector);
>> +        vioapic_update_EOI(d, vector);
>>  
>> -    hvm_dpci_msi_eoi(current->domain, vector);
>> +    hvm_dpci_msi_eoi(d, vector);
> 
> It might be worth retaining an ASSERT(current->domain == d) at this point.

For one, there would be many more places where this should then
be added. And then, even with the current (unpatched) code things
would go wrong if that wasn't already the case.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel