Re: [Xen-devel] [PATCH v2 for Xen 4.6 3/4] libxl: enabling XL to set per-VCPU parameters of a domain for RTDS scheduler

[Chong Li <lichong659@xxxxxxxxx>]

On Wed, Jun 17, 2015 at 7:32 AM, Dario Faggioli
<dario.faggioli@xxxxxxxxxx> wrote:
> On Wed, 2015-06-17 at 13:08 +0100, Ian Campbell wrote:
>> On Tue, 2015-06-09 at 18:18 +0200, Dario Faggioli wrote:
>> > On Mon, 2015-06-08 at 15:55 -0500, Chong Li wrote:
>> > > On Mon, Jun 8, 2015 at 10:56 AM, Dario Faggioli
>> >
>
>> For set overall I don't really think it matters too much if it sets
>> everything (i..e all vcpus and the defaults) so long as is a documented
>> effect of the API -- anyone who adds per-vcpu support would then be
>> aware of this and can adjust their code accordingly.
>>
> Exactly. Personally, I think I'd make per-domain set behave
> consistently, and hence use it for set the default.
>
>> For get I think saying it returns the defaults used for vcpus which
>> don't have something more explicit set is perfectly fine and doesn't
>> pose an upgrade wrinkle, since only those who are aware of the vcpu
>> settings would care about the distinction.
>>
> As said, I like this, great idea.
>
> Chong, what do you think? Can you make this happen?

I like this design, too. Will make it happen soon.
Thanks for these feedbacks.

Chong
>
> Regards,
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



-- 
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel