Re: [Xen-devel] [PATCH v2 02/17] x86/hvm: re-name struct hvm_mmio_handler to hvm_mmio_ops

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 17 June 2015 13:44
> To: Paul Durrant
> Cc: Andrew Cooper; xen-devel@xxxxxxxxxxxxxxxxxxxx; Keir (Xen.org)
> Subject: Re: [PATCH v2 02/17] x86/hvm: re-name struct hvm_mmio_handler
> to hvm_mmio_ops
> 
> >>> On 11.06.15 at 17:42, <paul.durrant@xxxxxxxxxx> wrote:
> > The struct just contains three methods and no data, so the name
> > hvm_mmio_ops more accurately reflects its content. A subsequent patch
> > introduces a new structure which more accurately warrants the name
> > hvm_mmio_handler so doing the rename in this purely cosmetic patch
> avoids
> > conflating functional and cosmetic changes in a single patch.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

> albeit
> 
> > @@ -182,21 +182,21 @@ int hvm_mmio_intercept(ioreq_t *p)
> >
> >      for ( i = 0; i < HVM_MMIO_HANDLER_NR; i++ )
> >      {
> > -        hvm_mmio_check_t check_handler =
> > -            hvm_mmio_handlers[i]->check_handler;
> > +        hvm_mmio_check_t check =
> > +            hvm_mmio_handlers[i]->check;
> 
> Does this still not fit on a single line?
> 

Probably does. I'll pull the change into v3 of the series if that's the case.

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel