Re: [Xen-devel] [RFC v2 13/15] Update Posted-Interrupts Descriptor during vCPU scheduling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.06.15 at 09:00, <feng.wu@xxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: Wednesday, June 10, 2015 2:44 PM
>> >>> On 08.05.15 at 11:07, <feng.wu@xxxxxxxxx> wrote:
>> > --- a/xen/include/xen/sched.h
>> > +++ b/xen/include/xen/sched.h
>> > @@ -142,6 +142,8 @@ struct vcpu
>> >
>> >      int              processor;
>> >
>> > +    int              pre_pcpu;
>> 
>> This again doesn't belong into the common structure (and should
>> be accompanied by a comment, and should be unsigned int).
> 
> I added three new member to 'struct vcpu' in this series:
>       - struct tasklet   vcpu_wakeup_tasklet;
>       - struct list_head blocked_vcpu_list;
>       - int              pre_pcpu;
> 
> I am trying to find a place specific to vmx to put them in, but the only one
> I find is ' struct arch_vmx_struct ', however, I don't think this is a good
> place, since it contains all vt-x stuff defined in the SDM. Do you think
> 'struct hvm_vcpu' is the right place?

No, arch_vmx_struct is. Taking active_list and active_cpu as
example, the structure clearly isn't limited to fields defined by
the SDM.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel