Re: [Xen-devel] [PATCH 08/27] tools/libxl: Extra APIs for the save helper

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/06/15 14:50, Ian Campbell wrote:
> On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
>> With libxl migration v2, there will be other moving parts which might fail,
>> requiring the helper to be stopped for reasons which are not its fault.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
>> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
>> ---
>>  tools/libxl/libxl_internal.h     |    8 ++++++++
>>  tools/libxl/libxl_save_callout.c |   16 ++++++++++++++++
>>  2 files changed, 24 insertions(+)
>>
>> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
>> index 4f204f9..3fcc37a 100644
>> --- a/tools/libxl/libxl_internal.h
>> +++ b/tools/libxl/libxl_internal.h
>> @@ -3182,6 +3182,14 @@ _hidden void libxl__xc_domain_restore(libxl__egc *egc,
>>  _hidden void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void,
>>                                             int rc, int retval, int 
>> errnoval);
>>  
>> +_hidden void libxl__save_helper_abort(libxl__egc *egc,
>> +                                      libxl__save_helper_state *shs);
>> +
>> +static inline bool libxl__save_helper_inuse(const libxl__save_helper_state 
>> *shs)
>> +{
>> +    return libxl__ev_child_inuse(&shs->child);
>> +}
> Will this be used other than in libxl__save_helper_abort?

The two are typically used together, but inuse() does need to be used
without abort() as part of joining 3 parallel tasks.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel