Re: [Xen-devel] [PATCH v2 COLOPre 11/13] tools/libxl: rename remus device to checkpoint device

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jun 12, 2015 at 02:30:46PM +0100, Wei Liu wrote:
> On Mon, Jun 08, 2015 at 11:43:15AM +0800, Yang Hongyang wrote:
> [...]
> > 
> > Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> > Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> > ---
> >  tools/libxl/Makefile                  |   2 +-
> >  tools/libxl/libxl_checkpoint_device.c | 327 
> > ++++++++++++++++++++++++++++++++++
> >  tools/libxl/libxl_internal.h          | 112 ++++++------
> >  tools/libxl/libxl_netbuffer.c         | 108 +++++------
> >  tools/libxl/libxl_nonetbuffer.c       |  10 +-
> >  tools/libxl/libxl_remus.c             |  76 ++++----
> >  tools/libxl/libxl_remus_device.c      | 327 
> > ----------------------------------
> >  tools/libxl/libxl_remus_disk_drbd.c   |  52 +++---
> >  tools/libxl/libxl_types.idl           |   4 +-
> 
> This only thing I need to complain is the change to IDL.
> 
> >      .kind = LIBXL__DEVICE_KIND_VBD,
> >      .setup = drbd_setup,
> >      .teardown = drbd_teardown,
> > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> > index 8a3d7ba..375c546 100644
> > --- a/tools/libxl/libxl_types.idl
> > +++ b/tools/libxl/libxl_types.idl
> > @@ -61,8 +61,8 @@ libxl_error = Enumeration("error", [
> >      (-15, "LOCK_FAIL"),
> >      (-16, "JSON_CONFIG_EMPTY"),
> >      (-17, "DEVICE_EXISTS"),
> > -    (-18, "REMUS_DEVOPS_DOES_NOT_MATCH"),
> > -    (-19, "REMUS_DEVICE_NOT_SUPPORTED"),
> > +    (-18, "CHECKPOINT_DEVOPS_DOES_NOT_MATCH"),
> > +    (-19, "CHECKPOINT_DEVICE_NOT_SUPPORTED"),
> 
> You should add two new error numbers.
> 

And in that case you might also need to go through all places to make
sure the correct error numbers are return. I.e. old remus code path
still returns REMUS error code and new CHECKPOINT code path returns new
error code.

I merely speak from API backward compatibility point of view. If you
think what I suggest doesn't make sense, please let me know.

Wei.


> Wei.
> 
> >      (-20, "VNUMA_CONFIG_INVALID"),
> >      (-21, "DOMAIN_NOTFOUND"),
> >      ], value_namespace = "")
> > -- 
> > 1.9.1
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel