Re: [Xen-devel] [v3][PATCH 02/16] xen/x86/p2m: introduce set_identity_p2m_entry

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Chen, Tiejun
> Sent: Thursday, June 11, 2015 9:15 AM
> 
> We will create this sort of identity mapping as follows:
> 
> If the gfn space is unoccupied, we just set the mapping. If the space
> is already occupied by 1:1 mappings, do nothing. Failed for any
> other cases.

"If space is already occupied by desired identity mapping, do nothing.
Otherwise, failure is returned."

> 
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>, plus one small
comment as below:


> +            printk(XENLOG_G_WARNING
> +                   "Cannot identity map d%d:%lx, already mapped to %lx.\n",
> +                   d->domain_id, gfn, mfn_x(mfn));

"Cannot setup identity map, ..., gfn already mapped to..."


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel