Re: [Xen-devel] [OSSTEST Nested PATCH v11 7/7] Add test job for nest test case

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

longtao.pang writes ("[OSSTEST Nested PATCH v11 7/7] Add test job for nest test 
case"):
> 1. This patch adds creation of the nested test job, when job creation
> procedure is invoked.
> 2. Set nested L1's vif model, nestedhvm feature, set specific disk
> size and memory size for nested test by make-flight.
...

This is nearly right, I think.

> +  job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-nested \
> +            test-nested xl $xenarch $dom0arch $qemuu_runvar \
> +            nestedl1_image=debian-7.2.0-amd64-CD-1.iso \
> +            nestedl1_vifmodel='e1000' \
> +            nestedl1_disksize='15000' \
> +            nestedl1_memsize='3072' \
> +            nestedl1_enable_nestedhvm='true' \
> +            nestedl1_guest_storage_size='20000' \
> +            nestedl2_image=debian-7.2.0-amd64-CD-1.iso \
> +            nestedl2_disksize='15000' \
> +            bios=$bios
> +            all_hostflags=$most_hostflags,hvm

Some observations:
 * The \ should be aligned to a column at the RHS.  If you did that
   you would have noticed that:
 * You are missing a \
 * Most of the '' are unnecessary.
 * Why do you specify the l2 disk size explicitly ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel