Re: [Xen-devel] [RFC v2 15/15] Add a command line parameter for VT-d posted-interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.15 at 11:07, <feng.wu@xxxxxxxxx> wrote:
> @@ -101,6 +101,12 @@ static void __init parse_iommu_param(char *s)
>              if ( iommu_intremap == 0 )
>                  iommu_intpost = 0;
>          }
> +        else if ( !strcmp(s, "intpost") )
> +        {
> +            iommu_intpost = val;
> +            if ( iommu_intremap == 0 )
> +                iommu_intpost = 0;
> +        }

This again highlights that you shouldn't be (repeatedly) doing the
"if no intremap then no intpost" here and elsewhere. Just do this
in one or two central places (two in case intremap getting cleared
requires intpost to be cleared in turn, while also requiring the
connection to be represented correctly before starting IOMMU
setup).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel