Re: [Xen-devel] [RFC v2 07/15] vt-d: Add API to update IRTE when VT-d PI is used

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.15 at 11:07, <feng.wu@xxxxxxxxx> wrote:
> +static inline void setup_posted_irte(
> +    struct iremap_entry *new_ire, struct pi_desc *pi_desc, uint8_t gvec)
> +{
> +    new_ire->post.urg = 0;
> +    new_ire->post.vector = gvec;
> +    new_ire->post.pda_l = (((u64)virt_to_maddr(pi_desc)) >>
> +                           (32 - PDA_LOW_BIT)) & PDA_MASK(LOW);
> +    new_ire->post.pda_h = (((u64)virt_to_maddr(pi_desc)) >> 32) &
> +                           PDA_MASK(HIGH);

Looking at this another time I can't see what the and-ing with
PAD_MASK() is supposed to be good for. Nor can I see the need
for the u64 casts. The two literal 32-s aren't ideal either, but I
guess tolerable.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel