Re: [Xen-devel] [PATCH 2/4] EFI/early: add /mapbs to map EfiBootServices{Code, Data}

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.06.15 at 16:03, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 09/06/15 14:53, Jan Beulich wrote:
>> From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>
>> To help on certain platforms to run.
>>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/arch/x86/efi/efi-boot.h
>> +++ b/xen/arch/x86/efi/efi-boot.h
>> @@ -148,12 +148,16 @@ static void __init efi_arch_process_memo
>>  
>>          switch ( desc->Type )
>>          {
>> -        default:
>> -            type = E820_RESERVED;
>> -            break;
>> -        case EfiConventionalMemory:
>>          case EfiBootServicesCode:
>>          case EfiBootServicesData:
>> +            if ( map_bs )
> 
> if ( !map_bs ) surely?  It is the else case which sets a type of E820_RAM.

No, we want it reserved when map_bs and treated as normal RAM
when !map_bs.

Jan

>> +            {
>> +        default:
>> +                type = E820_RESERVED;
>> +                break;
>> +            }
>> +            /* fall through */
>> +        case EfiConventionalMemory:
>>              if ( !trampoline_phys && desc->PhysicalStart + len <= 0x100000 
>> &&
>>                   len >= cfg.size && desc->PhysicalStart + len > cfg.addr )
>>                  cfg.addr = (desc->PhysicalStart + len - cfg.size) & 
>> PAGE_MASK;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel