Re: [Xen-devel] [PATCH OSSTEST v2] Stubdom test case

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 09, 2015 at 11:36:35AM +0100, Ian Campbell wrote:
> On Mon, 2015-06-08 at 20:54 +0100, Wei Liu wrote:
> > Currently only QEMU traditional supports stubdom, so we only create
> > 
> > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64
> > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm
> > test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64
> > test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm
> > 
> > Note that stubdom only supports serial='pty'. Piping serial to stderr
> > causes stubdom to exit abnormally.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Changes in v2:
> > 1. Don't set stubdom runvar for every test case.
> 
> >From the list of runvars I don't think this happened correctly:
> 
> > +xen-unstable               test-amd64-amd64-xl-qemut-debianhvm-amd64       
> >       enable_stubdom              false
> > +xen-unstable               test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm   
> >       enable_stubdom              false
> 
> etc etc
> 
> Also:
> 
> > +xen-unstable               test-amd64-amd64-xl-qemuu-debianhvm-amd64       
> >       enable_stubdom
> > +xen-unstable               test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm   
> >       enable_stubdom
> > +xen-unstable               test-amd64-amd64-xl-qemuu-ovmf-amd64            
> >       enable_stubdom
> 
> I don't think is desired.
> 
> > +  stubdom_suffix="";
> > +  if [ x$stubdom = xtrue ]; then
> > +      stubdom_suffix="-stubdom"
> > +  fi
> > +
> > +  job_create_test 
> > test-$xenarch$kern-$dom0arch-xl$qemuu_suffix$stubdom_suffix-$testname-amd64\
> >      test-debianhvm xl $xenarch $dom0arch $qemuu_runvar \
> >      enable_xsm=$xsm                             \
> > +    enable_stubdom=$stubdom                     \
> 
> if [ x$stubdom != x ] ; then
>         stubdom_runvar="enable_stubdom=$stubdom"
> fi
> 
> Then just pass $stubdom_runvar to job_create_test, this arranges that
> enable_stubdom is only set if a specific value is requested.
> 
> > +      for stubdom in true false ; do
> 
> for stubdom in true '' ; do
> 
> then arranges to pass the right things into the above. May need more or
> less quoting when $stubdom is used now.
> 

I made the changes you suggested. Now the diff looks like:

--- /dev/fd/63  2015-06-09 11:49:57.242809774 +0100
+++ /dev/fd/62  2015-06-09 11:49:57.242809774 +0100
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  all_hostflags               
arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  arch                        amd64
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  bios                        rombios
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  buildjob                    build-amd64
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  debianhvm_image             debian-7.2.0-amd64-CD-1.iso
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  device_model_version        qemu-xen-traditional
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  enable_stubdom              true
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  enable_xsm                  false
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  kernbuildjob                build-amd64-pvops
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  kernkind                    pvops
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  toolstack                   xl
+xen-unstable               test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64   
  xenbuildjob                 build-amd64
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm all_hostflags             
  arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm arch                      
  amd64
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm bios                      
  rombios
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm buildjob                  
  build-amd64-xsm
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm debianhvm_image           
  debian-7.2.0-amd64-CD-1.iso
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm device_model_version      
  qemu-xen-traditional
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm enable_stubdom            
  true
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm enable_xsm                
  true
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm kernbuildjob              
  build-amd64-pvops
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm kernkind                  
  pvops
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm toolstack                 
  xl
+xen-unstable               
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm xenbuildjob               
  build-amd64-xsm
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  all_hostflags               
arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  arch                        i386
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  bios                        rombios
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  buildjob                    build-i386
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  debianhvm_image             debian-7.2.0-amd64-CD-1.iso
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  device_model_version        qemu-xen-traditional
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  enable_stubdom              true
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  enable_xsm                  false
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  kernbuildjob                build-i386-pvops
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  kernkind                    pvops
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  toolstack                   xl
+xen-unstable               test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64    
  xenbuildjob                 build-amd64
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  all_hostflags             
  arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  arch                      
  i386
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  bios                      
  rombios
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  buildjob                  
  build-i386-xsm
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  debianhvm_image           
  debian-7.2.0-amd64-CD-1.iso
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  device_model_version      
  qemu-xen-traditional
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  enable_stubdom            
  true
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  enable_xsm                
  true
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  kernbuildjob              
  build-i386-pvops
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  kernkind                  
  pvops
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  toolstack                 
  xl
+xen-unstable               
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm  xenbuildjob               
  build-amd64-xsm

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel