[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 COLO 06/15] libxc/save: support COLO save





On 06/09/2015 05:10 PM, Andrew Cooper wrote:
On 09/06/15 10:09, Yang Hongyang wrote:




Shouldn't get_dirty_pfn be mandatory for COLO streams (even if it
is a
noop to start with) ?

It should be mandatory, it shouldn't be noop under COLO. perhaps we
should
add sanity check at the beginning. But problem is save side do not
have a param
passed from libxl to indicate the stream type(like
checkpointed_stream in
restore side). So we may need to add another XCFLAGS? Currently
there is
XCFLAGS_CHECKPOINTED which represents Remus, we might need to change
this to
XCFLAGS_STREAM_REMUS
XCFLAGS_STREAM_COLO
so that we can know what kind of stream we are handling?

checkpointed_stream started out as a bugfix for a legacy stream
migration breakage.  Really, this information should have been passed
right from the start.

Did I miss the bugfix? is it not in upstream?

c/s 7051d5c

Ah, you are talking about the restore side, I'm talking about the save
side checkpointed_stream, so I should also post a prereq patch to
add checkpointed_stream to the save side? or there's already the
fix out there?

Sorry for being unclear.  You will have to add one to the save side.
The restore side only has one as a bugfix.

Got it~ thanks!


~Andrew
.


--
Thanks,
Yang.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.